Context Navigation

web_ui.py.backup

Last change on this file was 1746, checked in by Александър Шопов, 17 years ago
Локални промени по trac
File size: 28.1 KB

Line
1	# -- coding: utf-8 --
2	#
3	# Copyright (C) 2003-2006 Edgewall Software
4	# Copyright (C) 2003-2005 Jonas Borgström <jonas@edgewall.com>
5	# All rights reserved.
6	#
7	# This software is licensed as described in the file COPYING, which
8	# you should have received as part of this distribution. The terms
9	# are also available at http://trac.edgewall.org/wiki/TracLicense.
10	#
11	# This software consists of voluntary contributions made by many
12	# individuals. For the exact contribution history, see the revision
13	# history and logs, available at http://trac.edgewall.org/log/.
14	#
15	# Author: Jonas Borgström <jonas@edgewall.com>
16
17	import os
18	import re
19	import time
20	from StringIO import StringIO
21
22	from trac.attachment import attachments_to_hdf, Attachment, AttachmentModule
23	from trac.config import BoolOption, Option
24	from trac.core import *
25	from trac.env import IEnvironmentSetupParticipant
26	from trac.ticket import Milestone, Ticket, TicketSystem, ITicketManipulator
27	from trac.ticket.notification import TicketNotifyEmail
28	from trac.Timeline import ITimelineEventProvider
29	from trac.util import get_reporter_id
30	from trac.util.datefmt import format_datetime, pretty_timedelta, http_date
31	from trac.util.html import html, Markup
32	from trac.util.text import CRLF
33	from trac.web import IRequestHandler
34	from trac.web.chrome import add_link, add_stylesheet, INavigationContributor
35	from trac.wiki import wiki_to_html, wiki_to_oneliner
36	from trac.mimeview.api import Mimeview, IContentConverter
37
38
39	class InvalidTicket(TracError):
40	"""Exception raised when a ticket fails validation."""
41
42
43	class TicketModuleBase(Component):
44	# FIXME: temporary place-holder for unified ticket validation until
45	# ticket controller unification is merged
46	abstract = True
47
48	ticket_manipulators = ExtensionPoint(ITicketManipulator)
49
50	def _validate_ticket(self, req, ticket):
51	# Always validate for known values
52	for field in ticket.fields:
53	if 'options' not in field:
54	continue
55	name = field['name']
56	if name in ticket.values and name in ticket._old:
57	value = ticket[name]
58	if value:
59	if value not in field['options']:
60	raise InvalidTicket('"%s" is not a valid value for '
61	'the %s field.' % (value, name))
62	elif not field.get('optional', False):
63	raise InvalidTicket('field %s must be set' % name)
64	# Custom validation rules
65	for manipulator in self.ticket_manipulators:
66	for field, message in manipulator.validate_ticket(req, ticket):
67	if field:
68	raise InvalidTicket("The ticket %s field is invalid: %s" %
69	(field, message))
70	else:
71	raise InvalidTicket("Invalid ticket: %s" % message)
72
73
74	class NewticketModule(TicketModuleBase):
75
76	implements(IEnvironmentSetupParticipant, INavigationContributor,
77	IRequestHandler)
78
79	# IEnvironmentSetupParticipant methods
80
81	def environment_created(self):
82	"""Create the `site_newticket.cs` template file in the environment."""
83	if self.env.path:
84	templates_dir = os.path.join(self.env.path, 'templates')
85	if not os.path.exists(templates_dir):
86	os.mkdir(templates_dir)
87	template_name = os.path.join(templates_dir, 'site_newticket.cs')
88	template_file = file(template_name, 'w')
89	template_file.write("""<?cs
90	####################################################################
91	# New ticket prelude - Included directly above the new ticket form
92	?>
93	""")
94
95	def environment_needs_upgrade(self, db):
96	return False
97
98	def upgrade_environment(self, db):
99	pass
100
101	# INavigationContributor methods
102
103	def get_active_navigation_item(self, req):
104	return 'newticket'
105
106	def get_navigation_items(self, req):
107	if not req.perm.has_permission('TICKET_CREATE'):
108	return
109	yield ('mainnav', 'newticket',
110	html.A('New Ticket', href=req.href.newticket(), accesskey=7))
111
112	# IRequestHandler methods
113
114	def match_request(self, req):
115	return re.match(r'/newticket/?$', req.path_info) is not None
116
117	def process_request(self, req):
118	req.perm.assert_permission('TICKET_CREATE')
119
120	db = self.env.get_db_cnx()
121
122	if req.method == 'POST' and 'owner' in req.args and \
123	not req.perm.has_permission('TICKET_MODIFY'):
124	del req.args['owner']
125
126	if req.method == 'POST' and not req.args.has_key('preview'):
127	self._do_create(req, db)
128
129	ticket = Ticket(self.env, db=db)
130	ticket.populate(req.args)
131	ticket.values['reporter'] = get_reporter_id(req, 'reporter')
132
133	if ticket.values.has_key('description'):
134	description = wiki_to_html(ticket['description'], self.env, req, db)
135	req.hdf['newticket.description_preview'] = description
136
137	req.hdf['title'] = 'New Ticket'
138	req.hdf['newticket'] = ticket.values
139
140	field_names = [field['name'] for field in ticket.fields
141	if not field.get('custom')]
142	if 'owner' in field_names:
143	curr_idx = field_names.index('owner')
144	if 'cc' in field_names:
145	insert_idx = field_names.index('cc')
146	else:
147	insert_idx = len(field_names)
148	if curr_idx < insert_idx:
149	ticket.fields.insert(insert_idx, ticket.fields[curr_idx])
150	del ticket.fields[curr_idx]
151
152	for field in ticket.fields:
153	name = field['name']
154	del field['name']
155	if name in ('summary', 'reporter', 'description', 'type', 'status',
156	'resolution'):
157	field['skip'] = True
158	elif name == 'owner':
159	field['label'] = 'Assign to'
160	if not req.perm.has_permission('TICKET_MODIFY'):
161	field['skip'] = True
162	elif name == 'milestone':
163	# Don't make completed milestones available for selection
164	options = field['options'][:]
165	for option in field['options']:
166	milestone = Milestone(self.env, option, db=db)
167	if milestone.is_completed:
168	options.remove(option)
169	field['options'] = options
170	req.hdf['newticket.fields.' + name] = field
171
172	if req.perm.has_permission('TICKET_APPEND'):
173	req.hdf['newticket.can_attach'] = True
174	req.hdf['newticket.attachment'] = req.args.get('attachment')
175
176	add_stylesheet(req, 'common/css/ticket.css')
177	return 'newticket.cs', None
178
179	# Internal methods
180
181	def _do_create(self, req, db):
182	if not req.args.get('summary'):
183	raise TracError('Tickets must contain a summary.')
184
185	ticket = Ticket(self.env, db=db)
186	ticket.populate(req.args)
187	ticket.values['reporter'] = get_reporter_id(req, 'reporter')
188	self._validate_ticket(req, ticket)
189
190	ticket.insert(db=db)
191	db.commit()
192
193	# Notify
194	try:
195	tn = TicketNotifyEmail(self.env)
196	tn.notify(ticket, newticket=True)
197	except Exception, e:
198	self.log.exception("Failure sending notification on creation of "
199	"ticket #%s: %s" % (ticket.id, e))
200
201	# Redirect the user to the newly created ticket
202	if req.args.get('attachment'):
203	req.redirect(req.href.attachment('ticket', ticket.id, action='new'))
204	else:
205	req.redirect(req.href.ticket(ticket.id))
206
207
208	class TicketModule(TicketModuleBase):
209
210	implements(INavigationContributor, IRequestHandler, ITimelineEventProvider,
211	IContentConverter)
212
213	default_version = Option('ticket', 'default_version', '',
214	"""Default version for newly created tickets.""")
215
216	default_type = Option('ticket', 'default_type', 'defect',
217	"""Default type for newly created tickets (''since 0.9'').""")
218
219	default_priority = Option('ticket', 'default_priority', 'major',
220	"""Default priority for newly created tickets.""")
221
222	default_milestone = Option('ticket', 'default_milestone', '',
223	"""Default milestone for newly created tickets.""")
224
225	default_component = Option('ticket', 'default_component', '',
226	"""Default component for newly created tickets""")
227
228	timeline_details = BoolOption('timeline', 'ticket_show_details', 'false',
229	"""Enable the display of all ticket changes in the timeline
230	(''since 0.9'').""")
231
232	# IContentConverter methods
233
234	def get_supported_conversions(self):
235	yield ('csv', 'Comma-delimited Text', 'csv',
236	'trac.ticket.Ticket', 'text/csv', 8)
237	yield ('tab', 'Tab-delimited Text', 'tsv',
238	'trac.ticket.Ticket', 'text/tab-separated-values', 8)
239	yield ('rss', 'RSS Feed', 'xml',
240	'trac.ticket.Ticket', 'application/rss+xml', 8)
241
242	def convert_content(self, req, mimetype, ticket, key):
243	if key == 'csv':
244	return self.export_csv(ticket, mimetype='text/csv')
245	elif key == 'tab':
246	return self.export_csv(ticket, sep='\t',
247	mimetype='text/tab-separated-values')
248	elif key == 'rss':
249	return self.export_rss(req, ticket)
250
251	# INavigationContributor methods
252
253	def get_active_navigation_item(self, req):
254	return 'tickets'
255
256	def get_navigation_items(self, req):
257	return []
258
259	# IRequestHandler methods
260
261	def match_request(self, req):
262	match = re.match(r'/ticket/([0-9]+)$', req.path_info)
263	if match:
264	req.args['id'] = match.group(1)
265	return True
266
267	def process_request(self, req):
268	req.perm.assert_permission('TICKET_VIEW')
269
270	action = req.args.get('action', 'view')
271
272	db = self.env.get_db_cnx()
273	id = int(req.args.get('id'))
274
275	ticket = Ticket(self.env, id, db=db)
276
277	if req.method == 'POST':
278	if not req.args.has_key('preview'):
279	self._do_save(req, db, ticket)
280	else:
281	# Use user supplied values
282	ticket.populate(req.args)
283	self._validate_ticket(req, ticket)
284
285	req.hdf['ticket.action'] = action
286	req.hdf['ticket.ts'] = req.args.get('ts')
287	req.hdf['ticket.reassign_owner'] = req.args.get('reassign_owner') \
288	or req.authname
289	req.hdf['ticket.resolve_resolution'] = req.args.get('resolve_resolution')
290	comment = req.args.get('comment')
291	if comment:
292	req.hdf['ticket.comment'] = comment
293	# Wiki format a preview of comment
294	req.hdf['ticket.comment_preview'] = wiki_to_html(
295	comment, self.env, req, db)
296	else:
297	req.hdf['ticket.reassign_owner'] = req.authname
298	# Store a timestamp in order to detect "mid air collisions"
299	req.hdf['ticket.ts'] = ticket.time_changed
300
301	self._insert_ticket_data(req, db, ticket,
302	get_reporter_id(req, 'author'))
303
304	mime = Mimeview(self.env)
305	format = req.args.get('format')
306	if format:
307	mime.send_converted(req, 'trac.ticket.Ticket', ticket, format,
308	'ticket_%d' % ticket.id)
309
310	# If the ticket is being shown in the context of a query, add
311	# links to help navigate in the query result set
312	if 'query_tickets' in req.session:
313	tickets = req.session['query_tickets'].split()
314	if str(id) in tickets:
315	idx = tickets.index(str(ticket.id))
316	if idx > 0:
317	add_link(req, 'first', req.href.ticket(tickets[0]),
318	'Ticket #%s' % tickets[0])
319	add_link(req, 'prev', req.href.ticket(tickets[idx - 1]),
320	'Ticket #%s' % tickets[idx - 1])
321	if idx < len(tickets) - 1:
322	add_link(req, 'next', req.href.ticket(tickets[idx + 1]),
323	'Ticket #%s' % tickets[idx + 1])
324	add_link(req, 'last', req.href.ticket(tickets[-1]),
325	'Ticket #%s' % tickets[-1])
326	add_link(req, 'up', req.session['query_href'])
327
328	add_stylesheet(req, 'common/css/ticket.css')
329
330	# Add registered converters
331	for conversion in mime.get_supported_conversions('trac.ticket.Ticket'):
332	conversion_href = req.href.ticket(ticket.id, format=conversion[0])
333	add_link(req, 'alternate', conversion_href, conversion[1],
334	conversion[3])
335
336	return 'ticket.cs', None
337
338	# ITimelineEventProvider methods
339
340	def get_timeline_filters(self, req):
341	if req.perm.has_permission('TICKET_VIEW'):
342	yield ('ticket', 'Ticket changes')
343	if self.timeline_details:
344	yield ('ticket_details', 'Ticket details', False)
345
346	def get_timeline_events(self, req, start, stop, filters):
347	format = req.args.get('format')
348
349	status_map = {'new': ('newticket', 'created'),
350	'reopened': ('newticket', 'reopened'),
351	'closed': ('closedticket', 'closed'),
352	'edit': ('editedticket', 'updated')}
353
354	href = format == 'rss' and req.abs_href or req.href
355
356	def produce((id, t, author, type, summary), status, fields,
357	comment, cid):
358	if status == 'edit':
359	if 'ticket_details' in filters:
360	info = ''
361	if len(fields) > 0:
362	info = ', '.join(['<i>%s</i>' % f for f in \
363	fields.keys()]) + ' changed<br />'
364	else:
365	return None
366	elif 'ticket' in filters:
367	if status == 'closed' and fields.has_key('resolution'):
368	info = fields['resolution']
369	if info and comment:
370	info = '%s: ' % info
371	else:
372	info = ''
373	else:
374	return None
375	kind, verb = status_map[status]
376	if format == 'rss':
377	title = 'Ticket #%s (%s %s): %s' % \
378	(id, type.lower(), verb, summary)
379	else:
380	title = Markup('Ticket <em title="%s">#%s</em> (%s) %s by %s',
381	summary, id, type, verb, author)
382	ticket_href = href.ticket(id)
383	if cid:
384	ticket_href += '#comment:' + cid
385	if status == 'new':
386	message = summary
387	else:
388	message = Markup(info)
389	if comment:
390	if format == 'rss':
391	message += wiki_to_html(comment, self.env, req, db,
392	absurls=True)
393	else:
394	message += wiki_to_oneliner(comment, self.env, db,
395	shorten=True)
396	return kind, ticket_href, title, t, author, message
397
398	# Ticket changes
399	if 'ticket' in filters or 'ticket_details' in filters:
400	db = self.env.get_db_cnx()
401	cursor = db.cursor()
402
403	cursor.execute("SELECT t.id,tc.time,tc.author,t.type,t.summary, "
404	" tc.field,tc.oldvalue,tc.newvalue "
405	" FROM ticket_change tc "
406	" INNER JOIN ticket t ON t.id = tc.ticket "
407	" AND tc.time>=%s AND tc.time<=%s "
408	"ORDER BY tc.time"
409	% (start, stop))
410	previous_update = None
411	for id,t,author,type,summary,field,oldvalue,newvalue in cursor:
412	if not previous_update or (id,t,author) != previous_update[:3]:
413	if previous_update:
414	ev = produce(previous_update, status, fields,
415	comment, cid)
416	if ev:
417	yield ev
418	status, fields, comment, cid = 'edit', {}, '', None
419	previous_update = (id, t, author, type, summary)
420	if field == 'comment':
421	comment = newvalue
422	cid = oldvalue and oldvalue.split('.')[-1]
423	elif field == 'status' and newvalue in ('reopened', 'closed'):
424	status = newvalue
425	else:
426	fields[field] = newvalue
427	if previous_update:
428	ev = produce(previous_update, status, fields, comment, cid)
429	if ev:
430	yield ev
431
432	# New tickets
433	if 'ticket' in filters:
434	cursor.execute("SELECT id,time,reporter,type,summary"
435	" FROM ticket WHERE time>=%s AND time<=%s",
436	(start, stop))
437	for row in cursor:
438	yield produce(row, 'new', {}, None, None)
439
440	# Attachments
441	if 'ticket_details' in filters:
442	def display(id):
443	return Markup('ticket %s', html.EM('#', id))
444	att = AttachmentModule(self.env)
445	for event in att.get_timeline_events(req, db, 'ticket',
446	format, start, stop,
447	display):
448	yield event
449
450	# Internal methods
451
452	def export_csv(self, ticket, sep=',', mimetype='text/plain'):
453	content = StringIO()
454	content.write(sep.join(['id'] + [f['name'] for f in ticket.fields])
455	+ CRLF)
456	content.write(sep.join([unicode(ticket.id)] +
457	[ticket.values.get(f['name'], '')
458	.replace(sep, '_').replace('\\', '\\\\')
459	.replace('\n', '\\n').replace('\r', '\\r')
460	for f in ticket.fields]) + CRLF)
461	return (content.getvalue(), '%s;charset=utf-8' % mimetype)
462
463	def export_rss(self, req, ticket):
464	db = self.env.get_db_cnx()
465	changes = []
466	change_summary = {}
467
468	description = wiki_to_html(ticket['description'], self.env, req, db)
469	req.hdf['ticket.description.formatted'] = unicode(description)
470
471	for change in self.grouped_changelog_entries(ticket, db):
472	changes.append(change)
473	# compute a change summary
474	change_summary = {}
475	# wikify comment
476	if 'comment' in change:
477	comment = change['comment']
478	change['comment'] = unicode(wiki_to_html(
479	comment, self.env, req, db, absurls=True))
480	change_summary['added'] = ['comment']
481	for field, values in change['fields'].iteritems():
482	if field == 'description':
483	change_summary.setdefault('changed', []).append(field)
484	else:
485	chg = 'changed'
486	if not values['old']:
487	chg = 'set'
488	elif not values['new']:
489	chg = 'deleted'
490	change_summary.setdefault(chg, []).append(field)
491	change['title'] = '; '.join(['%s %s' % (', '.join(v), k) for k, v \
492	in change_summary.iteritems()])
493	req.hdf['ticket.changes'] = changes
494	return (req.hdf.render('ticket_rss.cs'), 'application/rss+xml')
495
496
497	def _do_save(self, req, db, ticket):
498	if req.perm.has_permission('TICKET_CHGPROP'):
499	# TICKET_CHGPROP gives permission to edit the ticket
500	if not req.args.get('summary'):
501	raise TracError('Tickets must contain summary.')
502
503	if req.args.has_key('description') or req.args.has_key('reporter'):
504	req.perm.assert_permission('TICKET_ADMIN')
505
506	ticket.populate(req.args)
507	else:
508	req.perm.assert_permission('TICKET_APPEND')
509
510	# Mid air collision?
511	if int(req.args.get('ts')) != ticket.time_changed:
512	raise TracError("Sorry, can not save your changes. "
513	"This ticket has been modified by someone else "
514	"since you started", 'Mid Air Collision')
515
516	# Do any action on the ticket?
517	action = req.args.get('action')
518	actions = TicketSystem(self.env).get_available_actions(ticket, req.perm)
519	if action not in actions:
520	raise TracError('Invalid action')
521
522	# TODO: this should not be hard-coded like this
523	if action == 'accept':
524	ticket['status'] = 'assigned'
525	ticket['owner'] = req.authname
526	if action == 'resolve':
527	ticket['status'] = 'closed'
528	ticket['resolution'] = req.args.get('resolve_resolution')
529	elif action == 'reassign':
530	ticket['owner'] = req.args.get('reassign_owner')
531	ticket['status'] = 'new'
532	elif action == 'reopen':
533	ticket['status'] = 'reopened'
534	ticket['resolution'] = ''
535
536	self._validate_ticket(req, ticket)
537
538	now = int(time.time())
539	cnum = req.args.get('cnum')
540	replyto = req.args.get('replyto')
541	internal_cnum = cnum
542	if cnum and replyto: # record parent.child relationship
543	internal_cnum = '%s.%s' % (replyto, cnum)
544	if ticket.save_changes(get_reporter_id(req, 'author'),
545	req.args.get('comment'), when=now, db=db,
546	cnum=internal_cnum):
547	db.commit()
548
549	try:
550	tn = TicketNotifyEmail(self.env)
551	tn.notify(ticket, newticket=False, modtime=now)
552	except Exception, e:
553	self.log.exception("Failure sending notification on change to "
554	"ticket #%s: %s" % (ticket.id, e))
555
556	fragment = cnum and '#comment:'+cnum or ''
557	req.redirect(req.href.ticket(ticket.id) + fragment)
558
559	def _insert_ticket_data(self, req, db, ticket, reporter_id):
560	"""Insert ticket data into the hdf"""
561	replyto = req.args.get('replyto')
562	req.hdf['title'] = '#%d (%s)' % (ticket.id, ticket['summary'])
563	req.hdf['ticket'] = ticket.values
564	req.hdf['ticket'] = {
565	'id': ticket.id,
566	'href': req.href.ticket(ticket.id),
567	'replyto': replyto
568	}
569
570	# -- Ticket fields
571
572	for field in TicketSystem(self.env).get_ticket_fields():
573	if field['type'] in ('radio', 'select'):
574	value = ticket.values.get(field['name'])
575	options = field['options']
576	if field['name'] == 'milestone' \
577	and not req.perm.has_permission('TICKET_ADMIN'):
578	options = [opt for opt in options if not
579	Milestone(self.env, opt, db=db).is_completed]
580	if value and not value in options:
581	# Current ticket value must be visible even if its not in the
582	# possible values
583	options.append(value)
584	field['options'] = options
585	name = field['name']
586	del field['name']
587	if name in ('summary', 'reporter', 'description', 'type', 'status',
588	'resolution', 'owner'):
589	field['skip'] = True
590	req.hdf['ticket.fields.' + name] = field
591
592	req.hdf['ticket.reporter_id'] = reporter_id
593	req.hdf['ticket.description.formatted'] = wiki_to_html(
594	ticket['description'], self.env, req, db)
595
596	req.hdf['ticket.opened'] = format_datetime(ticket.time_created)
597	req.hdf['ticket.opened_delta'] = pretty_timedelta(ticket.time_created)
598	if ticket.time_changed != ticket.time_created:
599	req.hdf['ticket'] = {
600	'lastmod': format_datetime(ticket.time_changed),
601	'lastmod_delta': pretty_timedelta(ticket.time_changed)
602	}
603
604	# -- Ticket Change History
605
606	def quote_original(author, original, link):
607	if not 'comment' in req.args: # i.e. the comment was not yet edited
608	req.hdf['ticket.comment'] = '\n'.join(
609	['Replying to [%s %s]:' % (link, author)] +
610	['> %s' % line for line in original.splitlines()] + [''])
611
612	if replyto == 'description':
613	quote_original(ticket['reporter'], ticket['description'],
614	'ticket:%d' % ticket.id)
615	replies = {}
616	changes = []
617	cnum = 0
618	description_lastmod = description_author = None
619	for change in self.grouped_changelog_entries(ticket, db):
620	changes.append(change)
621	# wikify comment
622	comment = ''
623	if 'comment' in change:
624	comment = change['comment']
625	change['comment'] = wiki_to_html(comment, self.env, req, db)
626	if change['permanent']:
627	cnum = change['cnum']
628	# keep track of replies threading
629	if 'replyto' in change:
630	replies.setdefault(change['replyto'], []).append(cnum)
631	# eventually cite the replied to comment
632	if replyto == str(cnum):
633	quote_original(change['author'], comment,
634	'comment:%s' % replyto)
635	if 'description' in change['fields']:
636	change['fields']['description'] = ''
637	description_lastmod = change['date']
638	description_author = change['author']
639
640	req.hdf['ticket'] = {
641	'changes': changes,
642	'replies': replies,
643	'cnum': cnum + 1
644	}
645	if description_lastmod:
646	req.hdf['ticket.description'] = {'lastmod': description_lastmod,
647	'author': description_author}
648
649	# -- Ticket Attachments
650
651	req.hdf['ticket.attachments'] = attachments_to_hdf(self.env, req, db,
652	'ticket', ticket.id)
653	if req.perm.has_permission('TICKET_APPEND'):
654	req.hdf['ticket.attach_href'] = req.href.attachment('ticket',
655	ticket.id)
656
657	# Add the possible actions to hdf
658	actions = TicketSystem(self.env).get_available_actions(ticket, req.perm)
659	for action in actions:
660	req.hdf['ticket.actions.' + action] = '1'
661
662	def grouped_changelog_entries(self, ticket, db, when=0):
663	"""Iterate on changelog entries, consolidating related changes
664	in a `dict` object.
665	"""
666	changelog = ticket.get_changelog(when=when, db=db)
667	autonum = 0 # used for "root" numbers
668	last_uid = current = None
669	for date, author, field, old, new, permanent in changelog:
670	uid = date, author, permanent
671	if uid != last_uid:
672	if current:
673	yield current
674	last_uid = uid
675	current = {
676	'http_date': http_date(date),
677	'date': format_datetime(date),
678	'author': author,
679	'fields': {},
680	'permanent': permanent
681	}
682	if permanent and not when:
683	autonum += 1
684	current['cnum'] = autonum
685	# some common processing for fields
686	if field == 'comment':
687	current['comment'] = new
688	if old:
689	if '.' in old: # retrieve parent.child relationship
690	parent_num, this_num = old.split('.', 1)
691	current['replyto'] = parent_num
692	else:
693	this_num = old
694	current['cnum'] = int(this_num)
695	else:
696	current['fields'][field] = {'old': old, 'new': new}
697	if current:
698	yield current

Note: See TracBrowser for help on using the repository browser.

Download in other formats:

Original Format